Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE: fix single fetch generic as cast (again) #9957

Merged

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Sep 6, 2024

We had two checks to ensure that the generic type was a function. For back compat, we need to allow non-function types, but #9948 only removed one of the checks. This removes the other check.

Type tests didn't catch this as we only check single-fetch types assuming the outer checks that rely on interface merging pass. We can't test the whole SerializeFrom type with interface merging in our repo as that will override types in the entire repo to be single-fetch aware.

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: 3edeff3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit b66a4b9 into release-next Sep 6, 2024
5 checks passed
@pcattori pcattori deleted the pedro/fix-single-fetch-generic-as-cast-again branch September 6, 2024 18:06
Copy link
Contributor

github-actions bot commented Sep 6, 2024

🤖 Hello there,

We just published version 2.12.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 2.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant