Replace <Form /> input with generic field factory #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<State />` component has too much own logic which makes `State` based components more complex with additional `set` and `onChangeProp` helpers. In this diff I reimplemented `<Value />` as class and `<State />` and another components as `Value` based. This reduced bundle size with ~0.8kb (parsed) and significantly simplified components implementation.
In this diff I added `<Form />` generic `field` factory as
a replacement for `input` factory. The main difference is each
value can have now any type, not only strings like before.
The second change is more generic `onChange` method which accepts
either value, or event like object which has this structure
```js
{
target: {
value: T
}
}
```
This allows to work with components which emulates their event and
produces not string type.
TrySound
changed the title
<Form /> input with generic field factory
renatorib
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this diff I added
<Form />genericfieldfactory asa replacement for
inputfactory. The main difference is eachvalue can have now any type, not only strings like before.
The second change is more generic
onChangemethod which acceptseither value, or event like object which has this structure
This allows to work with components which emulates their event and
produces not string type.