apply suggestions

renovatebot · Feb 13, 2023 · a5af9b1 · a5af9b1
1 parent c2c35d9
commit a5af9b1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/lib/workers/repository/update/pr/index.spec.ts b/lib/workers/repository/update/pr/index.spec.ts
@@ -58,7 +58,7 @@ describe('workers/repository/update/pr/index', () => {
       title: prTitle,
       bodyStruct,
       state: 'open',
-      displayNumber: '123',
+      displayNumber: `Pull Request #${number}`,
     };
 
     const config: BranchConfig = {
@@ -767,7 +767,7 @@ describe('workers/repository/update/pr/index', () => {
           pr: existingPr,
         });
         expect(logger.logger.debug).toHaveBeenCalledWith(
-          '123 does not need updating'
+          'Pull Request #123 does not need updating'
         );
         expect(prCache.setPrCache).toHaveBeenCalledTimes(1);
       });
@@ -785,7 +785,7 @@ describe('workers/repository/update/pr/index', () => {
           pr: existingPr,
         });
         expect(logger.logger.debug).toHaveBeenCalledWith(
-          '123 does not need updating'
+          'Pull Request #123 does not need updating'
         );
         expect(logger.logger.debug).toHaveBeenCalledWith(
           'PR cache matches but it has been edited in the past 24hrs, so processing PR'

diff --git a/lib/workers/repository/update/pr/pr-cache.spec.ts b/lib/workers/repository/update/pr/pr-cache.spec.ts
@@ -30,7 +30,7 @@ describe('workers/repository/update/pr/pr-cache', () => {
       expect(getPrCache('branch_name')).toBeNull();
     });
 
-    it('return null if prCache is falsy', () => {
+    it('return null if prCache is null/undefined', () => {
       cache.getCache.mockReturnValue(dummyCache);
       expect(getPrCache('branch_name')).toBeNull();
     });

diff --git a/lib/workers/repository/update/pr/pr-cache.ts b/lib/workers/repository/update/pr/pr-cache.ts
@@ -9,11 +9,11 @@ export function getPrCache(branchName: string): PrCache | null {
     (branch) => branchName === branch.branchName
   );
 
-  if (branch?.prCache) {
-    return branch.prCache;
+  if (!branch?.prCache) {
+    return null;
   }
 
-  return null;
+  return branch.prCache;
 }
 
 // store the time a PR was last updated

diff --git a/lib/workers/repository/update/pr/pr-fingerprint.ts b/lib/workers/repository/update/pr/pr-fingerprint.ts
@@ -9,7 +9,7 @@ import { getElapsedHours } from '../../../../util/date';
 import type { BranchConfig } from '../../../types';
 
 // BranchUpgradeConfig - filtered
-interface FilteredBranchUpgradeConfig {
+export interface FilteredBranchUpgradeConfig {
   depName?: string;
   gitRef?: boolean;
   hasReleaseNotes?: boolean;