Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(platform/codecommit): add aws codebuild examples #19374

Merged
merged 8 commits into from
Mar 8, 2023
Merged

docs(platform/codecommit): add aws codebuild examples #19374

merged 8 commits into from
Mar 8, 2023

Conversation

PhilipAbed
Copy link
Collaborator

@PhilipAbed PhilipAbed commented Dec 13, 2022 •
edited
Loading

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

HonkingGoose
HonkingGoose suggested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes to start us with.

lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
@rarkins @HonkingGoose
Apply suggestions from code review
35153dd 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins changed the title doc: add aws codecommit codebuild examples docs: add aws codecommit codebuild examples Mar 4, 2023
@rarkins rarkins enabled auto-merge March 4, 2023 11:31
rarkins
rarkins previously approved these changes Mar 4, 2023
View reviewed changes
HonkingGoose
HonkingGoose suggested changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we're missing some more background information:

  • why should users use this?
  • why is it better than what they're already using
  • explain benefits and drawbacks of this method

lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Outdated Show resolved Hide resolved
lib/modules/platform/codecommit/index.md Show resolved Hide resolved
@viceice viceice changed the title docs: add aws codecommit codebuild examples docs(platform/codecommit): add aws codebuild examples Mar 7, 2023
rarkins and others added 2 commits March 7, 2023 08:08
@rarkins
Merge branch 'main' into patch-7
91d5cdb
@rarkins @HonkingGoose
Apply suggestions from code review
d6c18b7 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Mar 8, 2023
Merged via the queue into renovatebot:main with commit 6e0ef61 Mar 8, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.159.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

RahulGautamSingh pushed a commit to RahulGautamSingh/renovate that referenced this pull request Mar 19, 2023
@PhilipAbed @rarkins
@HonkingGoose @RahulGautamSingh
docs(platform/codecommit): add aws codebuild examples (renovatebot#19374
4749fff 
)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhilipAbed @renovate-release @rarkins @HonkingGoose