Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoreplace): set depIndex during flatten #20665

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 28, 2023

Changes

Context

Avoid needing depIndex typing during extract & lookup phases

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've managers which return deps out of order 😕

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 28, 2023

we've managers which return deps out of order 😕

As long as it's deterministic.. it's only used for autoreplace

@secustor secustor added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 2f8aa56 Feb 28, 2023
@secustor secustor deleted the refactor/dep-index branch February 28, 2023 10:42
@rarkins
Copy link
Collaborator Author

rarkins commented Feb 28, 2023

Should all of the upgrade.depIndex= be removed from auto-replace.spec.ts @rarkins ?

I didn't think so. They'll still be set prior to autoreplace. Why do you think?

@setchy
Copy link
Collaborator

setchy commented Feb 28, 2023

Should all of the upgrade.depIndex= be removed from auto-replace.spec.ts @rarkins ?

I didn't think so. They'll still be set prior to autoreplace. Why do you think?

all good - realized i misspoke this as soon as i hit enter 🙊 😅

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.154.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants