Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build kots with apko+melange in presubmit #3950

Closed
wants to merge 3 commits into from

Conversation

imjasonh
Copy link
Contributor

What this PR does / why we need it:

This PR adds a presubmit GitHub Actions workflow to build and publish a kots image from the PR's source, including relevant other packages like helm, kustomize, and kubectl. For now, only the latest kubectl is included in the image, but we should be able to add older supported kubectls relatively soon.

To do this, the PR adds an apko.yaml and melange.yaml to be used with (you guessed it) apko and melange to build kots into an APK and to install that APK into an image.

Which issue(s) this PR fixes:

None that I'm aware of.

Special notes for your reviewer:

None

Steps to reproduce

See apko_melange_build.md

Does this PR introduce a user-facing change?

None at this time, though this could be extended to produce user-visible images by this process either on pushes to main or at release-time.

NONE

Does this PR require documentation?

Yes, added in apko_melange_build.md

cc @denhamparry

Signed-off-by: Jason Hall <jason@chainguard.dev>
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@denhamparry denhamparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment back from our call today, all looks great but we need to confirm that the image being built shouldn't be used in production instances 🙌

apko_melange_build.md Show resolved Hide resolved
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@cbodonnell
Copy link
Contributor

We will need to do this PR from a branch as we cannot run the required workflows from forks at the moment. I've opened #3959 with these changes and will close this one out.

@cbodonnell cbodonnell closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants