Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates zstd and ruzstd #145

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Update crates zstd and ruzstd #145

merged 4 commits into from
Nov 7, 2022

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 2, 2022

Updating zstd is blocked by EmbarkStudios/puffin#98

@emilk emilk added the blocked can't make progress right now label Oct 2, 2022
@Wumpf
Copy link
Member

Wumpf commented Oct 2, 2022

can we have a bot for the more trivial updates / update notifications?

@emilk
Copy link
Member Author

emilk commented Oct 2, 2022

Sure, do you have one in mind?

@jondo2010
Copy link
Contributor

Looks like dependabot should be trivial to get up and running: bevyengine/bevy#570

@@ -528,10 +528,6 @@ fn save_to_file(log_db: &LogDb, path: &std::path::PathBuf) {
fn load_rrd_to_log_db(mut read: impl std::io::Read) -> anyhow::Result<LogDb> {
crate::profile_function!();

#[cfg(target_arch = "wasm32")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup

@emilk emilk changed the title Update crates Update crates zstd and ruzstd Oct 2, 2022
Cargo.lock Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Oct 3, 2022

Looks like dependabot should be trivial to get up and running: bevyengine/bevy#570

I have never used dependabot, but seems worth a shot!

@emilk
Copy link
Member Author

emilk commented Oct 10, 2022

Waiting for a new puffin release…

@emilk
Copy link
Member Author

emilk commented Nov 7, 2022

I finally got around to making a new puffin release, so this should soon be green 🤞

@emilk emilk marked this pull request as ready for review November 7, 2022 11:50
@emilk emilk merged commit c9e13ed into main Nov 7, 2022
@emilk emilk deleted the update-crates branch November 7, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked can't make progress right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants