Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Taxes for Items #2392

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: Update Taxes for Items #2392

merged 1 commit into from
Jul 11, 2024

Conversation

Nihantra-Patel
Copy link
Contributor

Version 15

fixes: frappe/erpnext#42241

Before:

  • If you remove all taxes from the GST HSN Code, the "Update Taxes for Items" button disappears. This means you can't update taxes for all items at once and have to remove taxes from each item individually, which is a time-consuming process.
scrnli_11_07_2024_15-06-01.mp4

After:

  • remove frm.doc.taxes.length from if condition
scrnli_11_07_2024_15-08-47.mp4

@vorasmit vorasmit merged commit 39378f3 into resilient-tech:develop Jul 11, 2024
8 checks passed
This was referenced Jul 11, 2024
Merged
Merged
vorasmit added a commit that referenced this pull request Jul 12, 2024
@vorasmit
Merge pull request #2394 from resilient-tech/mergify/bp/version-14-ho…
336ec21 
…tfix/pr-2392

fix: Update Taxes for Items (backport #2392)
vorasmit added a commit that referenced this pull request Jul 12, 2024
@vorasmit
Merge pull request #2395 from resilient-tech/mergify/bp/version-15-ho…
caff15b 
…tfix/pr-2392

fix: Update Taxes for Items (backport #2392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

item Tax template should Auto Update after updating tax in hsn document.
2 participants
@Nihantra-Patel @vorasmit