Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky cluster_marker::tests::cluster_marker_is_updated when running it locally #1626

Closed
tillrohrmann opened this issue Jun 13, 2024 · 1 comment · Fixed by #1628
Closed

Flaky cluster_marker::tests::cluster_marker_is_updated when running it locally #1626

tillrohrmann opened this issue Jun 13, 2024 · 1 comment · Fixed by #1628
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

Flaky cluster_marker::tests::cluster_marker_is_updated when running it locally.
@tillrohrmann tillrohrmann self-assigned this Jun 13, 2024
@tillrohrmann
Copy link
Contributor Author

tillrohrmann commented Jun 13, 2024 •
edited
Loading

The problem is that some tests use the same test directory and then end up interfering with each other by overwriting the same tmp cluster marker file.

tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Jun 13, 2024
@tillrohrmann
Use different directories for cluster marker tests
9f16b20 
Multiple NamedTempFiles are created in the same directory. Therefore,
it happens that the cluster marker test can interfere with each other.
This commit separates the cluster marker tests by creating a temporary
directory in which the cluster marker file gets created.

This fixes restatedev#1626.
@tillrohrmann tillrohrmann mentioned this issue Jun 13, 2024
Merged
tillrohrmann added a commit that referenced this issue Jun 14, 2024
@tillrohrmann
Use different directories for cluster marker tests
1ba6ce4 
Multiple NamedTempFiles are created in the same directory. Therefore,
it happens that the cluster marker test can interfere with each other.
This commit separates the cluster marker tests by creating a temporary
directory in which the cluster marker file gets created.

This fixes #1626.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use different directories for cluster marker tests tillrohrmann/restate
1 participant
@tillrohrmann