Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pinned tikv-jemallocator to fix CI #1234

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update pinned tikv-jemallocator to fix CI #1234

merged 1 commit into from
Feb 28, 2024

Conversation

jackkleeman
Copy link
Contributor

pcholakov
pcholakov approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tillrohrmann
tillrohrmann reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me. Can you quickly explain what the problem with the old revision was @jackkleeman?

@jackkleeman
Copy link
Contributor Author

See error here https://github.com/restatedev/restate/actions/runs/8077393693/job/22067814278
Sometimes the submodule couldn't be pulled because the commit isn't found - the commit isn't on a branch or tag in the jemalloc repo so I think github doesn't always serve it

@jackkleeman jackkleeman merged commit bf5accf into restatedev:main Feb 28, 2024
5 checks passed
@jackkleeman jackkleeman deleted the jemalloc-pin-fix branch February 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann left review comments

@pcholakov pcholakov pcholakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackkleeman @pcholakov @tillrohrmann