Fix panics datafusion #1618
Merged
Fix panics datafusion #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
fix-panics-datafusion
branch
from
48efc7d
to
facc2f5
Compare
…Make all those methods return Result, and not panic anymore. Also the Result is on the individual stream elements, such that a consumer can decide whether to individually treat failures on stream item, or on the whole stream.
To do that, I've defined a trait `Builder` in table_util.rs, and I have pushed the logic that iterates the stream and fills the builder directly in the `LocalPartitionScanner` implementation.
slinkydeveloper
force-pushed
the
fix-panics-datafusion
branch
from
facc2f5
to
6312997
Compare
tillrohrmann
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks for removing the sources of panics from the runtime @slinkydeveloper. The changes look good to me. +1 for merging.
tillrohrmann
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Move the `all_*` methods from PartitionStore to the relative traits. Make all those methods return Result, and not panic anymore. Also the Result is on the individual stream elements, such that a consumer can decide whether to individually treat failures on stream item, or on the whole stream. * Adapt to the changes in storage_api * Unify all the code scanning `PartitionStore` in datafusion. To do that, I've defined a trait `Builder` in table_util.rs, and I have pushed the logic that iterates the stream and fills the builder directly in the `LocalPartitionScanner` implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.