Lazily calculate value when using StyledTable::add_kv_row_if and predicate is true #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate is true We use StyledTable::add_kv_row_if to check if a value exists. We should only access the value if the predicate passes. That's why this command changes the value parameter into a closure that is evaluated if the predicate is true. This fixes restatedev#1631.
tillrohrmann
force-pushed
the
issues/1631
branch
from
7e4b06d
to
49163e5
Compare
AhmedSoliman
approved these changes
Jun 14, 2024
|
Thanks for the review @AhmedSoliman. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
StyledTable::add_kv_row_ifto check if a value exists. We should only access the value if the predicate passes. That's why this command changes the value parameter into a closure that is evaluated if the predicate is true.This fixes #1631.