Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable info log by default #331

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Enable info log by default #331

merged 1 commit into from
Apr 24, 2023

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Apr 24, 2023 •
edited
Loading

Part of #289

@slinkydeveloper slinkydeveloper added this to the 1A milestone Apr 24, 2023
tillrohrmann
tillrohrmann approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @slinkydeveloper. The changes look good and it works. I had one comment concerning enabling warn for all other components. +1 for merging after resolving the comment.

src/tracing_instrumentation/src/lib.rs Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit 8c53a18 into restatedev:main Apr 24, 2023
@slinkydeveloper slinkydeveloper deleted the info_log_default branch April 24, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1A
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slinkydeveloper @tillrohrmann