Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard reverse routing parameter patch #870

Closed
wants to merge 1 commit into from

Conversation

notzippy
Copy link
Collaborator

This resolves issue #869 . Revel incorrectly would append a parameter to a route path with a wild card (like /foo/*bar) in it.

Signed-off-by: NotZippy <notzippy@gmail.com>
@pushrax
Copy link
Contributor

pushrax commented Feb 17, 2015

Can you add a regression test for this one?

@notzippy
Copy link
Collaborator Author

So you would like a test added to router_test.go ? How is that test file launched ?
revel run github.com/revel/revel ????

@ghost
Copy link

ghost commented Feb 18, 2015

@notzippy, no that is a regular golang test file. So, it's go test github.com/revel/revel/....

@brendensoares
Copy link
Member

@notzippy @pushrax @pushrax I added a test to cover this issue and merged it as #870.

@brendensoares brendensoares added this to the v0.12 milestone Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants