Force auth frontend #435
Merged
Force auth frontend #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
awtkns
approved these changes
May 2, 2023
| @@ -76,6 +78,18 @@ const ChatWindow = ({ | |||
| } | |||
| }); | |||
|
|
|||
| const handleChangeWebSearch = (value: boolean) => { | |||
| // Change this value when we can no longer support web search | |||
| const WEB_SEARCH_ALLOWED = false; | |||
There was a problem hiding this comment.
might be best to make this feature flag: eg NEXT_PUBLIC_FF_WEB_SEARCH_ENABLED. That way we can toggle it just by changing an env var
There was a problem hiding this comment.
Yeah can change it in the future if we need. We shouldn't have this check for long I imagine
Comment on lines
+85
to
+90
| if (WEB_SEARCH_ALLOWED) { | ||
| setIsWebSearchEnabled(value); | ||
| } else { | ||
| openSorryDialog?.(); | ||
| setIsWebSearchEnabled(false); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (WEB_SEARCH_ALLOWED) { | |
| setIsWebSearchEnabled(value); | |
| } else { | |
| openSorryDialog?.(); | |
| setIsWebSearchEnabled(false); | |
| } | |
| if (!WEB_SEARCH_ALLOWED) openSorryDialog?.(); | |
| setIsWebSearchEnabled(WEB_SEARCH_ALLOWED); |
| return ( | ||
| <Dialog header="Sorry! 😭" isShown={show} close={close}> | ||
| <p>Due to costs, we've had to momentarily disable web search 🌐</p> | ||
| <br /> |
There was a problem hiding this comment.
nit: Ideally instead of
i think we can just use flex gap spacing. eg: flex flex-col gap-2
Co-authored-by: Adam Watkins <hello@awtkns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is all frontend only