Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Pin @vitejs/plugin-vue version (1.8.1 breaks vue-class-component); bump other deps #245

Merged
merged 8 commits into from
Nov 5, 2021

Conversation

charles-allen
Copy link
Contributor

@charles-allen charles-allen commented Nov 5, 2021

📸 Screenshots

Me wiping & reinstalling node_modules, with ^ deps:
trap2

📝 Summary

PBIs:

  • Resolves N/A

Description:

  • I hit an intermittent bug during the [210] Migrate to monorepo & pnpm #237 PR; I assumed it was due to pnpm (probably related to hoisting)...
    • Actually it seems that the latest version of Vue 3 breaks vue-class-component. I have pinned vue on 3.2.19 @vitejs/plugin-vue on 1.8.0 (which appears to be the last working version).
    • I stumbled into this issue (twice -- the second time helped me solve it!) by wiping & reinstalling node_modules, and picking up new versions
    • Edit: I found the relevant issue:
      fix(plugin-vue): use __vccOpts for vue-class-component vitejs/vite#5374
  • I also aggressively updated everything else (which fixes a ton of vulnerabilities described by audit as "severe")
  • The latest Vue ESLint adds some new rules (I fixed the easy ones & temporarily overrode the harder ones)

💡 More ideas

🙋 Requests for feedback

  • Shoot me now...

✅ DoD

  • Tested & no regression (MANUAL)
  • Respects SRP
  • // TODO XYZ all resolved
  • PBIs created for deferred work
  • Documented (N/A)

@charles-allen charles-allen self-assigned this Nov 5, 2021
@charles-allen charles-allen changed the title Pin Vue version (breaks vue-class-component); bump other deps [HOTFIX] Pin Vue version (breaks vue-class-component); bump other deps Nov 5, 2021
@charles-allen charles-allen added the devops Code quality, delivery, and production maintenance label Nov 5, 2021
@charles-allen charles-allen changed the title [HOTFIX] Pin Vue version (breaks vue-class-component); bump other deps [HOTFIX] Pin @vitejs/plugin-vue version (1.8.1 breaks vue-class-component); bump other deps Nov 5, 2021
Copy link
Contributor

@Nutto55 Nutto55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 Nice work 😄
🤔 Sound like it is time to learn composition api

@charles-allen charles-allen merged commit 6c0d578 into develop Nov 5, 2021
@charles-allen charles-allen deleted the feature/bump-deps branch November 5, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Code quality, delivery, and production maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants