Add HCL variable support from varfiles #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
support-hcl-in-varfile
branch
2 times, most recently
from
5d83f96
to
7a387f2
Compare
Previously, all variables extracted from a file were considered strings. This patch now detects lists as HCL variables and create them accordingly. Drive-by: * Fixes the `getTag()` function in the Magefile. Fixes #13
rgreinho
force-pushed
the
support-hcl-in-varfile
branch
from
7a387f2
to
05c0274
Compare
|
Thanks @rgreinho ! I will build from master and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Previously, all variables extracted from a file were considered strings.
This patch now detects lists as HCL variables and create them
accordingly.
Drive-by:
getTag()function in the Magefile.Checklist:
Fixes: #13