Adjust compile threads for low memory boards when installing Respeaker driver #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannisroot
changed the title
|
A user has reported that this did fix the driver installation issues under bookworm and pi zero w2 |
|
After this PR is merged, #167 can be merged too. |
tannisroot
force-pushed
the
adjust_compile_threads
branch
from
b9b5156
to
2b39450
Compare
|
Force push didn't change anything but simplify how threads are set, instead of dividing by 2 it just hard sets threads to 2 if there is 512 mb or less memory and more than 2 cores (which is the case for Pi Zero 2W). In my testing it was enough to avoid OOM issue. |
|
@synesthesiam could you review and merge this? This is needed to workaround OOM issues when installing the driver on bookworm. Thanks! |
synesthesiam
requested changes
Jun 26, 2024
|
Minor change, and we'll be good. Thanks! |
Co-authored-by: Michael Hansen <hansen.mike@gmail.com>
Commited the change, can be merged now! (not sure why it's not auto-merging). |
synesthesiam
approved these changes
Jul 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the latest, non-legacy Raspberry PI OS Lite version, it seems that some people with Pi Zero 2W boards are unable to install the respeaker driver due to running out of memory, see #170 (comment)
Someone adjusted swap size to workaround this, and it compiled successfully.
In my less intrusive workaround, I've changed the script to compile the dkms module with half the threads if the board has less than 512MBs of main memory. This should lower the memory requirements and avoid OOM issues.