Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing version to match release tag #17

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Changing version to match release tag #17

merged 1 commit into from
Jul 8, 2020

Conversation

andymiller96
Copy link
Contributor

No description provided.

jacobsee
jacobsee approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@jacobsee jacobsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Need to make sure we keep in mind for future releases... i.e. the 1.2.0 tag will still have the wrong version in it but we will be more diligent about it in 1.2.1+

@mcanoy mcanoy merged commit c03afa7 into rht-labs:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsee jacobsee jacobsee approved these changes

@mcanoy mcanoy mcanoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andymiller96 @jacobsee @mcanoy