Removed printStackTrace from main code and placed into logger so it c…

…an be silenced if needed
rickbrian · Feb 7, 2020 · 89cd69a · 89cd69a
1 parent 2f8e6d7
commit 89cd69a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/rootbeerlib/src/main/java/com/scottyab/rootbeer/RootBeer.java b/rootbeerlib/src/main/java/com/scottyab/rootbeer/RootBeer.java
@@ -215,7 +215,7 @@ private String[] propsReader() {
             String propVal = new Scanner(inputstream).useDelimiter("\\A").next();
             return propVal.split("\n");
         } catch (IOException | NoSuchElementException e) {
-            e.printStackTrace();
+            QLog.e(e);
             return null;
         }
     }
@@ -227,7 +227,7 @@ private String[] mountReader() {
             String propVal = new Scanner(inputstream).useDelimiter("\\A").next();
             return propVal.split("\n");
         } catch (IOException | NoSuchElementException e) {
-            e.printStackTrace();
+            QLog.e(e);
             return null;
         }
     }

diff --git a/rootbeerlib/src/main/java/com/scottyab/rootbeer/util/QLog.java b/rootbeerlib/src/main/java/com/scottyab/rootbeer/util/QLog.java
@@ -49,6 +49,12 @@ public static void e(final Object obj) {
         }
     }
 
+    public static void e(final Exception e) {
+        if (isELoggable()) {
+            e.printStackTrace();
+        }
+    }
+
     public static void w(final Object obj, final Throwable cause) {
         if (isWLoggable()) {
             Log.w(TAG, getTrace() + String.valueOf(obj));
@@ -122,16 +128,6 @@ private static String getTrace() {
                 + lineNo + "] - ";
     }
 
-    /**
-     * Prints the stack trace to mubaloo log and standard log
-     *
-     * @param e the exception to log
-     */
-    public static void handleException(final Exception e) {
-        QLog.e(e.toString());
-        e.printStackTrace();
-    }
-
     private QLog() {
     }
 }