follow opencc conversion chain #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorphobia
reviewed
Aug 11, 2023
|
|
eagleoflqj
requested review from
amorphobia and
lotem
and removed request for
amorphobia
amorphobia
reviewed
Aug 12, 2023
amorphobia
approved these changes
Aug 12, 2023
|
This is still wrong. Basically, it only works with mono-character and fails when there are terms and phrases in the text |
|
The restriction from OpenCC determines it’s not easy to be perfect if possible. Current status is more acceptable than previous as at least correct result is available to users. Treat extraneous words just as irrelevant ones. |
|
it has nothing to do with OpenCC. On the contrary, OpenCC gives correct results in such cases. The problem is the implementation of conversion chain in rime |
groverlynn
pushed a commit
to groverlynn/librime
that referenced
this pull request
Sep 27, 2023
* follow opencc conversion chain * when a dict doesn't contain a word, pass as-is * de-duplication
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
* follow opencc conversion chain * when a dict doesn't contain a word, pass as-is * de-duplication
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
* follow opencc conversion chain * when a dict doesn't contain a word, pass as-is * de-duplication
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
* follow opencc conversion chain * when a dict doesn't contain a word, pass as-is * de-duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #652
Feature
Describe feature of pull request
Unit test
Manual test
EDIT: the screenshot actually shows a clear bug 🤦♂️. See below for a corrected one.
Code Review
Additional Info