fix: chord_composer should stop at super and caps by default #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not. Thanks. Don't say "reject", it made me think those keys are |
lotem
approved these changes
Feb 6, 2024
ksqsf
changed the title
|
Sure. Updated the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Stop composing chord when a key event is super or caps modified, just like ctrl, alt, and shift.
Currently, super+any key will be consumed by rime when chord typing.
Unit test
Manual test
Type
super+athe raw sequence will be cleared and the key can be forwarded to the client application.Code Review
Additional Info