Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality from better-discord-screenshare-plugin #95

Closed
userMacieG opened this issue Apr 13, 2023 · 3 comments
Closed

Add functionality from better-discord-screenshare-plugin #95

userMacieG opened this issue Apr 13, 2023 · 3 comments

Comments

@userMacieG
Copy link

Plugin https://github.com/tinguy1/better-discord-screenshare-plugin is no longer supported, so functionality of that plugin would be nice.
@riolubruh
Copy link
Owner

riolubruh commented Apr 17, 2023 •
edited
Loading

Sorry, I don't quite get what you mean. Better Discord Screenshare has a fairly similar feature set to this plugin. Things that BDS have that this plugin does not are as follows:
Ability to choose video codec
Ability to choose audio codec
Ability to capture and encode in different resolutions/fpses (YABP4Nitro sets the capture and encode to the same settings)
A good UI

Other than a good UI (which I have no idea how to do), the features that BDS provides that this plugin does not are not really that substantial.

@userMacieG
Copy link
Author

Ability to choose video codec is main thing that is missing in yabd.

riolubruh added a commit that referenced this issue Apr 19, 2023
@riolubruh
4.5.0 -- Video Codecs, Activities Removed
82f5780 
I regret to inform everyone that after going through the effort of fixing the Activity scripts, almost all Activities have been given a deeper level of authentication that cannot be bypassed. Furthermore, Discord has added a custom Activity URL feature themselves if you enable Developer Activity Shelf in settings. That is why, with a heavy heart, I must announce that the Activity Bypass has been removed, most likely permanently. The fixed code has been left in the plugin (although commented out) for people who are curious, and will be deleted in the next update.
The changelog is as follows:
-Activity Bypasses have been removed.
+Added Preferred Video Codec. Choose your preferred video codec between H.264, AV1, VP8, and VP9. Suggested by @userMacieG in #95
+Fixed a problem where bitrates were not applying correctly
+Fixed warnings from module filtering
+Miscellaneous small changes
@riolubruh
Copy link
Owner

riolubruh commented Apr 19, 2023 •
edited
Loading

Ability to choose video codec is main thing that is missing in yabd.

Added in 4.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@userMacieG @riolubruh