Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): add CreateFunctionExecutor & bind_create_function #828

Merged

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jan 13, 2024

As titled, cc @wangrunji0408.

P.S. Some of the logic in bind_create_function is the same as create_sql_function. 😄

Signed-off-by: Michael Xu <xzhseh@gmail.com>
Signed-off-by: Michael Xu <xzhseh@gmail.com>
@xzhseh xzhseh force-pushed the xzhseh/create-function-executor branch from 90bdad7 to 0526e69 Compare January 13, 2024 18:20
@wangrunji0408 wangrunji0408 self-requested a review January 29, 2024 14:14
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 29, 2024
Merged via the queue into risinglightdb:main with commit 7b49788 Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants