Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toolchain and dependencies #830

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

caicancai
Copy link
Contributor

No description provided.

Signed-off-by: caicancai <2356672992@qq.com>
@caicancai caicancai marked this pull request as draft February 16, 2024 08:52
@TennyZhuang
Copy link
Collaborator

Do you need any help? I also want to bump the toolchain for async gen.

@caicancai
Copy link
Contributor Author

Do you need any help? I also want to bump the toolchain for async gen.

I am trying this part of the work, but I am not very familiar with the rust toolchain ecology, I can close this pr if the big guy is willing to do this part of the work

@wangrunji0408
Copy link
Member

CI shows the clippy panicked
Let's try a newer version?

Signed-off-by: caicancai <2356672992@qq.com>
Signed-off-by: caicancai <2356672992@qq.com>
@caicancai caicancai marked this pull request as ready for review February 18, 2024 13:03
@caicancai
Copy link
Contributor Author

caicancai commented Feb 18, 2024

CI shows the clippy panicked Let's try a newer version?

@TennyZhuang @wangrunji0408 Thank you

Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Feb 19, 2024
Merged via the queue into risinglightdb:main with commit 650c9c7 Feb 19, 2024
4 checks passed
@caicancai caicancai deleted the update branch February 19, 2024 05:27
@caicancai
Copy link
Contributor Author

Do you need any help? I also want to bump the toolchain for async gen.

finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants