Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binder): support sql udf with unnamed parameters #835

Merged

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Mar 2, 2024

A minimal support for sql udf with unnamed parameters.

@xzhseh xzhseh force-pushed the xzhseh/sql-udf-unnamed-params branch from 81371a9 to 8b1bbd8 Compare March 2, 2024 19:49
Signed-off-by: Michael Xu <xzhseh@gmail.com>
Signed-off-by: Michael Xu <xzhseh@gmail.com>
Signed-off-by: Michael Xu <xzhseh@gmail.com>
Signed-off-by: Michael Xu <xzhseh@gmail.com>
@xzhseh xzhseh force-pushed the xzhseh/sql-udf-unnamed-params branch from 7b0f209 to 6838ff0 Compare March 2, 2024 20:49
@wangrunji0408 wangrunji0408 self-requested a review March 4, 2024 09:06
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into risinglightdb:main with commit 6f97db7 Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants