feat: add label for skipif and onlyif conditions
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
reviewed
Jun 8, 2023
| /// | ||
| /// The engine name is a label by default. | ||
| #[clap(long = "label")] | ||
| labels: Vec<String>, |
There was a problem hiding this comment.
Multiple labels are supported so that combinations are possible. e.g. risingwave + in-mem for this use case. And I'd like to use labels java/python in UDF tests.
There was a problem hiding this comment.
Why not e.g., risingwave-in-mem? 🤪
There was a problem hiding this comment.
I think multi labels are more flexible. 🤪
xxchan
reviewed
Jun 8, 2023
xxchan
reviewed
Jun 8, 2023
| validator: default_validator, | ||
| column_type_validator: default_column_validator, | ||
| testdir: None, | ||
| sort_mode: None, | ||
| hash_threshold: 0, | ||
| labels: [db.engine_name().to_string()].into_iter().collect(), |
There was a problem hiding this comment.
Oh, I get it. So the labels are the trait method + others?
There was a problem hiding this comment.
I'm not sure whether multiple labels are really needed, but OK to me.
xxchan
reviewed
Jun 8, 2023
Co-authored-by: xxchan <xxchan22f@gmail.com> Signed-off-by: Runji Wang <wangrunji0408@163.com>
skyzh
approved these changes
Jun 8, 2023
xxchan
approved these changes
Jun 9, 2023
|
@skyzh Could you publish the sqllogictest-engines and sqllogictest crate? Thanks! |
6 tasks
|
Published and added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now add
--labeloptions to skip commands. resolve #177For example:
This PR also bumps version to v0.14.0.