Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add create and drop sink test for nexmark #8686

Merged
merged 7 commits into from
Apr 11, 2023
Merged

test: add create and drop sink test for nexmark #8686

merged 7 commits into from
Apr 11, 2023

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Mar 21, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously the drop sink can be stuck (not sure if it is stuck forever or comes back to normal after a long period of time)
After #8672, the drop sink is super fast.
We add drop sink into e2e tests to avoid similar problems from happening again in the future

Checklist For Contributors

  • [ ] I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • [ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the component/test Test related issue. label Mar 21, 2023
@lmatz lmatz requested a review from BugenZhao March 21, 2023 08:52
@tabVersion tabVersion self-requested a review March 21, 2023 08:59
@BugenZhao
Copy link
Member

There seem too many logs. Can we disable these?

2023-03-21T09:19:25.490674Z  INFO risingwave_frontend::scheduler::hummock_snapshot_manager: Unpin epoch 4073400070111232 with RPC

2023-03-21T09:14:24.546932Z  INFO risingwave_meta::hummock::manager: report_scale_compactor_info ScaleCompactorInfo { running_cores: 1, total_cores: 16, waiting_compaction_bytes: 0 } suggest_scale_out_core 0

@lmatz
Copy link
Contributor Author

lmatz commented Mar 21, 2023

timeout?

@BugenZhao
Copy link
Member

image

ci/scripts/e2e-source-test.sh Outdated Show resolved Hide resolved
ci/scripts/e2e-source-test.sh Outdated Show resolved Hide resolved
ci/scripts/e2e-source-test.sh Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #8686 (95b6316) into main (e294250) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8686      +/-   ##
==========================================
- Coverage   70.88%   70.87%   -0.01%     
==========================================
  Files        1197     1197              
  Lines      199012   199012              
==========================================
- Hits       141069   141059      -10     
- Misses      57943    57953      +10     
Flag Coverage Δ
rust 70.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao
Copy link
Member

The e2e-source lasts too long and becomes the bottleneck of the workflow. 🥵 Is it possible to split it into another step?

@BugenZhao BugenZhao requested a review from xxchan March 22, 2023 03:54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the speed expected?

image

The e2e-source lasts too long and becomes the bottleneck of the workflow.

Can we move to e2e-sink?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird, I tested locally on my Mac, and it finishes very fast besides the 20-second sleep on purpose...
🤔
After Bugen's two PR that makes drop sink completely async, drop sink is expected to be very fast.

This PR intends to detect this type of anomaly though.

@xxchan
Copy link
Member

xxchan commented Mar 22, 2023

Wait, can we run the tests in parallel?! 🥵

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically LGTM
lets keep watching the CI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tabVersion
Copy link
Contributor

Wait, can we run the tests in parallel?! 🥵

Yes, any step behind build can run in parallel

@xxchan
Copy link
Member

xxchan commented Mar 23, 2023

Wait, can we run the tests in parallel?! 🥵

Yes, any step behind build can run in parallel

I mean sqllogictest -j

@lmatz
Copy link
Contributor Author

lmatz commented Apr 11, 2023

Succeed once after moving to the e2e sink test:
https://buildkite.com/risingwavelabs/pull-request/builds/21269#01876fa5-474c-41a5-8a35-ebcaa51afaa8

Good to merge?

@lmatz lmatz added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit 07cd8b7 Apr 11, 2023
@lmatz lmatz deleted the lz/nexmark_sink branch April 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants