Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump toolchain to nightly-2023-04-07 #9051

Merged
merged 8 commits into from
Apr 11, 2023
Merged

chore: bump toolchain to nightly-2023-04-07 #9051

merged 8 commits into from
Apr 11, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

rust LLVM is updated to 16.0.2. Wanted to try this for #6205 (But it doesn't fix it 🤪

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Note: rust LLVM is updated to 16.0.2
@xxchan
Copy link
Member Author

xxchan commented Apr 7, 2023

image

Oh mama this is scary

@xxchan
Copy link
Member Author

xxchan commented Apr 7, 2023

This is a regression in 2023-04-01, 2023-03-31 is ok

@xxchan
Copy link
Member Author

xxchan commented Apr 7, 2023

Regression in 22a7a19f9333bc1fcba97ce444a3515cb5fb33e6
rust-lang/rust@22a7a19

searched nightlies: from nightly-2023-03-31 to nightly-2023-04-01
regressed nightly: nightly-2023-04-01
searched commit range: rust-lang/rust@ec2f40c...5e1d329
regressed commit: rust-lang/rust@22a7a19

bisected with cargo-bisect-rustc v0.6.6

Host triple: aarch64-apple-darwin
Reproduce with:

cargo bisect-rustc --script test.sh --start=2023-03-31 --end=2023-04-01 

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #9051 (5365d04) into main (e294250) will increase coverage by 0.00%.
The diff coverage is 81.25%.

@@           Coverage Diff           @@
##             main    #9051   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files        1197     1197           
  Lines      199012   199014    +2     
=======================================
+ Hits       141069   141072    +3     
+ Misses      57943    57942    -1     
Flag Coverage Δ
rust 70.88% <81.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd_all/src/lib.rs 100.00% <ø> (ø)
src/common/src/lib.rs 100.00% <ø> (ø)
src/connector/src/lib.rs 81.63% <ø> (ø)
src/expr/macro/src/lib.rs 92.85% <ø> (ø)
src/expr/src/lib.rs 100.00% <ø> (ø)
src/frontend/src/lib.rs 22.72% <ø> (ø)
src/frontend/src/scheduler/distributed/query.rs 69.57% <0.00%> (+0.32%) ⬆️
src/java_binding/src/lib.rs 0.29% <ø> (ø)
src/meta/src/lib.rs 0.90% <ø> (ø)
src/meta/src/rpc/service/hummock_service.rs 0.00% <0.00%> (ø)
... and 13 more

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan enabled auto-merge April 11, 2023 12:00
@xxchan xxchan added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit 5a61944 Apr 11, 2023
@xxchan xxchan deleted the xxchan/grubby-tahr branch April 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants