Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blockId as a fallback, rather than source of truth #126

Conversation

tntmarket
Copy link
Contributor

@tntmarket tntmarket commented Jul 10, 2020

This undoes the changes in #116, and uses blockIndex as a fallback for blockId instead.

Some manual tests

Rescheduling Dates:

rescheduling dates

Remember block when opening in sidebar

Remember block when opening in sidebar

Blocks inserted before

blocks inserted before

Issues with detecting when the main page changes

I didn't figure out how to make it so your main page resets to the first block when you switch pages.

The issue is that the main panel persists even when you switch pages. In order to reset the block upon switching main pages, I have to detect whether the main page changed. This doesn't seem trivial though, because even when you swap pages, the .roam-article div remains intact.

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stvad Stvad merged commit 3efcc3e into roam-unofficial:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants