Search pages in page or references filter #130
Conversation
| } | ||
| } | ||
|
|
||
| const searchInputId = 'searchInputBox' |
There was a problem hiding this comment.
nit: but maybe prefix like roam-toolkit--searchInputBox
Clarifies it's not a native roam thing, and stands out to people who might want to customize the css.
There was a problem hiding this comment.
I'm curious why two dashes? :)
There was a problem hiding this comment.
Hmm, I guess it's a convention for denoting hierarchy from http://getbem.com/introduction/ , although the meaning isn't quite the same here
| const eventTarget = event.target as HTMLElement | ||
| if (!eventTarget) return | ||
|
|
||
| const filterPageButtonClicked = eventTarget.className === 'bp3-button' |
There was a problem hiding this comment.
I think src/ts/core/roam/selectors.ts has 'bp3-button'
There was a problem hiding this comment.
Hmm, is there a nice way to check if an element or one of it's children is matching a selector?
| searchInput.style.cssText = 'width:200px;display:flex' | ||
| searchElementsContainer.appendChild(searchInput) | ||
|
|
||
| searchInput.addEventListener('input', onFilterInput) |
There was a problem hiding this comment.
I think naming the consequence of event handlers (showButtonsMatchingQuery) is usually more helpful than naming the cause, because readers probably already know "this happens when a search is inputted", but they don't know "what happens, and why does this handler exist" yet
|
Kudos, SonarCloud Quality Gate passed!
|
Based on #83 by @GitMurf
