Get from title to top block wiithout mousing #50
Conversation
This reverts commit 20ad956.
… the top Problem: Moving from title editing to block editing currently requires the mouse. Solution: This mod provides a means of getting from title to blocks without leaving the keyboard.
…at the top Problem: When no blocks are currently selected, Roam requires a mouse click to begin editing. Solution: This mod allows block editing without leaving the keyboard.
| @@ -6,7 +6,7 @@ | |||
| "icons": { | |||
| "128": "assets/icon-128.png" | |||
| }, | |||
| "content_security_policy": "script-src 'self'; object-src 'self'", | |||
| "content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'", | |||
There was a problem hiding this comment.
this was actually removed for a reason, you need to revert that locally for development, but should not commit it
There was a problem hiding this comment.
Oops! Sorry for the misunderstanding. Will avoid in future.
| const isExitingTitle = (ev: KeyboardEvent) => { | ||
| return ev.target.parentElement instanceof HTMLHeadingElement; | ||
| } | ||
| const isNoBlockSelected = (ev: KeyboardEvent) => { |
There was a problem hiding this comment.
I think you can use something like !Roam.getActiveRoamNode() to check for this
There was a problem hiding this comment.
Ok. I'll give that a shot…assuming it's even worth continuing with this small feature given your note re: Cmd+Enter. Either way, I'll test it just to learn a little bit more. :)
There was a problem hiding this comment.
Yeah, not sure if makes sense to include this given Cmd+Enter exists. I still appreciate you working on this though, and look forward to you building more things! ;)
| document.addEventListener('keydown', ev => { | ||
| const enter = 'Enter'; | ||
| const isExitingTitle = (ev: KeyboardEvent) => { | ||
| return ev.target.parentElement instanceof HTMLHeadingElement; |
There was a problem hiding this comment.
given that you define this within the context of the handler, the event is already in the closure, so you don't have to pass it to the function.
in fact you can probably just use variable instead of function..
| @@ -20,6 +20,20 @@ const dispatchMap = new Map([ | |||
|
|
|||
| browser.runtime.onMessage.addListener((command) => dispatchMap.get(command)?.()); | |||
|
|
|||
| document.addEventListener('keydown', ev => { | |||
| const enter = 'Enter'; | |||
There was a problem hiding this comment.
not sure if this constant adds much value tbh
There was a problem hiding this comment.
Yeah. I initially tried using the event.keyCode, which is much less clear in the condition check, but then neglected to inline the constant again when I switched to ev.key.
|
hmm, not sure since when, but apparently Roam has similar functionality natively now via |
|
I decided to try this again from scratch, taking into account your feedback and making additional improvements. Closing in favor of #54. :) |
Addresses #50 . Feedback welcome!