Skip to content

Commit

Permalink
Merge pull request #243 from yvanoers/master
Browse files Browse the repository at this point in the history
Let cron depend on interface for parsers instead of fixed parser
  • Loading branch information
robfig authored Nov 25, 2019
2 parents 3a6eb7f + 9c7462b commit b7cc47d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion cron.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ type Cron struct {
logger Logger
runningMu sync.Mutex
location *time.Location
parser Parser
parser ScheduleParser
nextID EntryID
jobWaiter sync.WaitGroup
}

// ScheduleParser is an interface for schedule spec parsers that return a Schedule
type ScheduleParser interface {
Parse(spec string) (Schedule, error)
}

// Job is an interface for submitted cron jobs.
type Job interface {
Run()
Expand Down
2 changes: 1 addition & 1 deletion option.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func WithSeconds() Option {
}

// WithParser overrides the parser used for interpreting job schedules.
func WithParser(p Parser) Option {
func WithParser(p ScheduleParser) Option {
return func(c *Cron) {
c.parser = p
}
Expand Down

0 comments on commit b7cc47d

Please sign in to comment.