Ensure that the browser process is stopped in the exit handler.

Signed-off-by: Titus Fortner <titusfortner@gmail.com>
robrich · Mar 4, 2016 · 0d942bc · 0d942bc
1 parent 4be7c77
commit 0d942bc
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/rb/lib/selenium/webdriver/chrome/service.rb b/rb/lib/selenium/webdriver/chrome/service.rb
@@ -83,7 +83,7 @@ def stop
 
           @process.poll_for_exit STOP_TIMEOUT
         rescue ChildProcess::TimeoutError
-          # ok, force quit
+        ensure
           @process.stop STOP_TIMEOUT
         end
 

diff --git a/rb/lib/selenium/webdriver/edge/service.rb b/rb/lib/selenium/webdriver/edge/service.rb
@@ -83,7 +83,7 @@ def stop
 
           @process.poll_for_exit STOP_TIMEOUT
         rescue ChildProcess::TimeoutError
-          # ok, force quit
+        ensure
           @process.stop STOP_TIMEOUT
         end
 

diff --git a/rb/lib/selenium/webdriver/firefox/service.rb b/rb/lib/selenium/webdriver/firefox/service.rb
@@ -82,7 +82,7 @@ def stop
 
           @process.poll_for_exit STOP_TIMEOUT
         rescue ChildProcess::TimeoutError
-          # ok, force quit
+        ensure
           @process.stop STOP_TIMEOUT
         end
 

diff --git a/rb/lib/selenium/webdriver/phantomjs/service.rb b/rb/lib/selenium/webdriver/phantomjs/service.rb
@@ -78,7 +78,7 @@ def stop
 
           @process.poll_for_exit STOP_TIMEOUT
         rescue ChildProcess::TimeoutError
-          # ok, force quit
+        ensure
           @process.stop STOP_TIMEOUT
 
           if Platform.jruby? && !$DEBUG