Fix obfuscate failed by extracting SwiftFileList file #68
Conversation
| @@ -28,7 +28,7 @@ final class XcodeProjectBuilder { | |||
| let arguments: [String] = [projectParameter, projectToBuild, "-scheme", schemeToBuild] | |||
| let cleanTask = Process() | |||
| cleanTask.launchPath = path | |||
| cleanTask.arguments = ["clean", "build"] + arguments | |||
| cleanTask.arguments = ["clean", "build"] + arguments + ["-sdk", "iphonesimulator"] | |||
There was a problem hiding this comment.
Is this necessary on Xcode 11? What happens if you have a watchOS target on your app?
There was a problem hiding this comment.
Without -sdk parameter, the build will be failed with error
Code Signing Error: "SwiftShieldExample" requires a provisioning profile. Select a provisioning profile in the Signing & Capabilities editor.
Code Signing Error: Code signing is required for product type 'Application' in SDK 'iOS 13.0'
Of course most of projects should contain these items. But if we want to obfuscate the demo project and without code sign and profiles, this job will not be successful.
There was a problem hiding this comment.
Ahhh that's intended -- for the example project, you need to sign it manually for it to work. I should update the README to reflect this.
If it works for regular projects, we can keep this change out.
There was a problem hiding this comment.
OK, I have reverted these changes.
ldp940622
force-pushed
the
xcode11-compatible
branch
from
6c8a29f
to
2cf2222
Compare
ldp940622
force-pushed
the
xcode11-compatible
branch
from
2cf2222
to
682aaec
Compare
|
Thanks a lot for working on this! I'll update the READMEs separately. |
This PR wants to fix #64 and make tool compatible with Xcode11.
However, I noticed that the Circle.CI seems not worked for this repo.
Maybe we need a better way to test these changes on CI.