Move build.sh execution from %posttrans to rockstor-build.service #61 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kstor#61 Move the execution of build.sh from outside of the constraints of the rpm packaging system, to the level of OS orchestration: systemd. ## Includes: - Removal of redundant Poetry install/update. We now assume this of our build host, and assert rockstor-build.service / build.sh as the sole source of truth for this. - Simplify %check scriptlet by similarly removing redundancy re GNUPG & 'pass' setup/config. Referencing rockstor-build.service / build.sh, and rockstor-pre.service for these build host assumptions. - Minor comment corrections /updates. - Remove redundant poetry paths for readability. - Align poetry install logging, during %check with current build.sh.
TestingSee the linked rockstor-core partner pull request from the following comment onwards: |
phillxnet
deleted the
61-Move-build.sh-execution-from-%posttrans-to-rockstor-build.service
branch
This was referenced Feb 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the execution of build.sh from outside of the constraints of the rpm packaging system, to the level of OS orchestration: systemd.
Fixes #61
Includes:
Partner Pull Request: