Skip to content

Commit

Permalink
Merge pull request swiftlang#74568 from ktoso/wip-remove-old-clang-wo…
Browse files Browse the repository at this point in the history
…rkaround

[Concurrency] Remove OPTNONE workaround for old clang version
  • Loading branch information
ktoso committed Jun 20, 2024
2 parents 174983f + a43abe6 commit e85b461
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
6 changes: 0 additions & 6 deletions include/swift/Runtime/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,6 @@ extern uintptr_t __COMPATIBILITY_LIBRARIES_CANNOT_CHECK_THE_IS_SWIFT_BIT_DIRECTL
#define SWIFT_ASYNC_CONTEXT
#endif

#if __has_attribute(optnone)
#define SWIFT_OPTNONE __attribute__((optnone))
#else
#define SWIFT_OPTNONE
#endif

// SWIFT_CC(swiftasync) is the Swift async calling convention.
// We assume that it supports mandatory tail call elimination.
#if __has_attribute(swiftasynccall)
Expand Down
4 changes: 1 addition & 3 deletions stdlib/public/Concurrency/Actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2076,12 +2076,10 @@ static void runOnAssumedThread(AsyncTask *task, SerialExecutorRef executor,
asImpl(executor.getDefaultActor())->unlock(true);
}

// TODO (rokhinip): Workaround rdar://88700717. To be removed with
// rdar://88711954
SWIFT_CC(swiftasync)
static void swift_task_switchImpl(SWIFT_ASYNC_CONTEXT AsyncContext *resumeContext,
TaskContinuationFunction *resumeFunction,
SerialExecutorRef newExecutor) SWIFT_OPTNONE {
SerialExecutorRef newExecutor) {
auto task = swift_task_getCurrent();
assert(task && "no current task!");

Expand Down

0 comments on commit e85b461

Please sign in to comment.