Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rollbar_username #7

Merged
merged 8 commits into from
May 26, 2020
Merged

Add support for rollbar_username #7

merged 8 commits into from
May 26, 2020

Conversation

jackton1
Copy link
Contributor

@jackton1 jackton1 commented May 25, 2020 •
edited
Loading

@basoko
Copy link
Contributor

basoko commented May 25, 2020

Hi @jackton1 !

Thanks for contributing to this! I think that as status is optional, if we use an input parameter for the rollbar_username we can't know if the $3 value if for status or rollbar_username.

I think that we could add it as environment variable. Could you please make that change to be used from an env var?

Thanks!

@jackton1
Copy link
Contributor Author

jackton1 commented May 25, 2020 •
edited
Loading

Sure

  • Update README.md.

@jackton1
Copy link
Contributor Author

Hi @jackton1 !

Thanks for contributing to this! I think that as status is optional, if we use an input parameter for the rollbar_username we can't know if the $3 value if for status or rollbar_username.

I think that we could add it as environment variable. Could you please make that change to be used from an env var?

Thanks!

Done @basoko

basoko
basoko reviewed May 25, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jackton1 jackton1 requested a review from basoko May 25, 2020 19:30
basoko
basoko approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@basoko basoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackton1 for this contribution!

@basoko basoko merged commit a91ad3e into rollbar:master May 26, 2020
@gavinsharp gavinsharp mentioned this pull request Jun 19, 2020
Merged
@jackton1 jackton1 deleted the patch-1 branch September 25, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basoko basoko basoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackton1 @basoko