Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Werkzeug DeprecationWarning #410

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

compyman
Copy link
Contributor

@compyman compyman commented Jun 23, 2022

Description of the change

This PR changes the flask integration setup to import Request instead of BaseRequest from Werkzeug.

This is motivated by the deprecation warning I'm receiving that says:

{pyenv_dir}/site-packages/rollbar/__init__.py:1160: DeprecationWarning: 'BaseRequest' is deprecated and will be removed in Werkzeug 2.1. Use 'isinstance(obj, Request)' instead.
if WerkzeugRequest and isinstance(request, WerkzeugRequest):

All the tests pass, and I can't on the face of it see a reason to prefer BaseRequest over Request generally

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
    My flake8 does not pass locally, but none of those are related to this change
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@nk9
Copy link

nk9 commented Oct 6, 2022

This is showing up in my unit tests as a warning whenever I run them. Would love to see this PR accepted so I can get back to the land of green. 😄

@danielmorell danielmorell self-assigned this Oct 10, 2022
@danielmorell danielmorell self-requested a review November 22, 2022 12:05
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @compyman for bringing this to our attention!

@danielmorell danielmorell merged commit f95076d into rollbar:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants