Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SonarCloud from the project #341

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Remove SonarCloud from the project #341

merged 2 commits into from
Feb 13, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 13, 2024

Description of the change

This PR removes SonarCloud from the project after experiencing sudden problems with build-wrapper in the CI, the issues has been raised here, but given other users presenting similar issues and a lack of solution, this may not have a solution that's worth implementing at this point, if any.

Other reports:

Last working PR:

No changes were done since then to justify an issue suddenly appearing with this. SonarCloud may be having trouble using macos-latest, or Xcode 14.x.

Slack refs:


Note:

  • Read and server-post access tokens for the deploys feature unit tests were updated since they were expired.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 13, 2024
@matux matux force-pushed the matux/remove-sonar branch 2 times, most recently from b911127 to 67286ad Compare February 13, 2024 18:04
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@matux matux merged commit 71c1613 into master Feb 13, 2024
1 check passed
@matux matux deleted the matux/remove-sonar branch February 13, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants