Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to use source map without minified url? #75

Closed
yosimasu opened this issue Jul 5, 2019 · 2 comments
Closed

Is it possible to use source map without minified url? #75

yosimasu opened this issue Jul 5, 2019 · 2 comments

Comments

@yosimasu
Copy link

yosimasu commented Jul 5, 2019

Hi,

I am using the code push service to patch the react native bundle of my clients.
When clients have updated from code push, there would be many different minified urls.
I can not upload source maps for all minified urls.
Is it possible to refer source map by version only?

螢幕快照 2019-07-05 11 40 26
@kousun12
Copy link

kousun12 commented Aug 20, 2019 •
edited
Loading

I'm also curious as to how we can get sourcemaps to work with code-push. bugsnag seems to have solved this by allowing a glob / wildcard minified url, and i assume they just match on that and un minify in that case. the rollbar docs say

minified_url

The URL or filename of the minified file. Can start with http: or https:, which we'll strip off.

which made me want to believe that filename meant that you'd do a similar matching if the full url didn't match. can i get some clarification on this, or thoughts / pointers on codepush support in general?

@waltjones
Copy link
Contributor

Code Push URLs are supported in v0.6.1. PR: #82

Related Rollbar.js PR: rollbar/rollbar.js#780

URLs will be sent in the form:
iOS: http://reactnativehost/main.jsbundle
Android: http://reactnativehost/index.android.bundle

If you still have any problems with it, please reopen with details.

yosimasu added a commit to yosimasu/rollbar.js that referenced this issue Feb 20, 2020
@yosimasu
Add CodePush Rewrite Rule
53313b5 
From my rollbar dashboard, I get code push url like:

```
http://reactnativehost//var/mobile/Containers/Data/Application/52713282-5486-4447-8D8F-683E8835FE7A/Library/Application Support/CodePush/220c9e918e33429e06837cbddcbcc0e8c0c6e5fd9519abe662c9d8d9d2eb9db5/CodePush/main.jsbundle
```

So I add an extra rule to match above url

Refer to

rollbar#780
rollbar/rollbar-react-native#75
@yosimasu yosimasu mentioned this issue Feb 20, 2020
Merged
mudetroit pushed a commit to rollbar/rollbar.js that referenced this issue Mar 14, 2024
@yosimasu
Add CodePush Rewrite Rule
bb17ea4 
From my rollbar dashboard, I get code push url like:

```
http://reactnativehost//var/mobile/Containers/Data/Application/52713282-5486-4447-8D8F-683E8835FE7A/Library/Application Support/CodePush/220c9e918e33429e06837cbddcbcc0e8c0c6e5fd9519abe662c9d8d9d2eb9db5/CodePush/main.jsbundle
```

So I add an extra rule to match above url

Refer to

#780
rollbar/rollbar-react-native#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@waltjones @yosimasu @kousun12