Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed formatting rules from eslintrc, leave it to prettier #116

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 29, 2024

Description of the change

We have formatting rules defined in eslintrc, since we've formalized the usage of prettier across the entire project, we can drop these and let prettier handle all things formatting.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested a review from mudetroit February 29, 2024 15:41
@matux matux self-assigned this Feb 29, 2024
@matux matux merged commit 0d4e620 into main Feb 29, 2024
6 checks passed
@matux matux deleted the matux/eslint-config branch February 29, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants