Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make post install pages gracefully handle failure modes #12

Merged
merged 4 commits into from
Mar 19, 2020

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Mar 17, 2020

The currrent install pages call the setup/install routines on a continuous polling loop and do not differentiate between whether a step failed or has not executed yet. (Pending vs. failed.) In the failure case, or timeout, there are no diagnostic hints for the user.

The looping behavior on error conditions can cause floods of emails to the customer's inbox and/or occurrences to the Rollbar account.

Key changes in this update:

  • All steps now happen synchronously, except adding the email address, which will be discussed below.
  • Completion of each step is verified, and state updated, at the time the step is completed.
  • Because adding the email address must be done in a future, the UI will pause at that step for the user to manually advance.
  • The UI is updated using a reRender target, and full page loads aren't needed.
  • In general, polling and/or refresh loops are no longer needed or used.
  • Incorrect tokens (like client tokens) are gracefully handled, returning control to the user with a message.
  • Help text to resolve common failure conditions. For now, this focuses on wrong tokens, and insufficient network permissions.

@waltjones waltjones changed the title WIP: Make post install pages detect and handle failure modes Make post install pages detect and handle failure modes Mar 19, 2020
@waltjones waltjones changed the title Make post install pages detect and handle failure modes Make post install pages gracefully handle failure modes Mar 19, 2020
@waltjones waltjones merged commit 6775713 into master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant