Enable sending items from triggers, futures, etc. via platform events #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Rollbar.log('info', 'Message from the Apex SDK', SendMethod.FUTURE); | ||
| Test.stopTest(); | ||
|
|
||
| // Asserts valid payload in the mock. |
There was a problem hiding this comment.
This looks like a no-opp unit test.. I don't fully understand the logic here, but I would at least confirm the data payload is correct
There was a problem hiding this comment.
Because of the way future methods execute, the asserts have to be in the mock. That's why the comment is there.
| Rollbar.log('info', 'Message from the Apex SDK', SendMethod.EVENT); | ||
| Test.stopTest(); | ||
|
|
||
| // Asserts valid payload in the mock. |
There was a problem hiding this comment.
This looks like a no-opp unit test.. I don't fully understand the logic here, but I would at least confirm the data payload is correct
There was a problem hiding this comment.
Because of the way future methods execute, the asserts have to be in the mock. That's why the comment is there.
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now, Rollbar items were always sent on a synchronous callout (HTTP request). This has several limitations:
This PR allows items to be sent via Platform Event, Future, or synchronous, with Platform Event being the default. Using Platform Events has numerous advantages:
More detailed information here:
https://rollbar.quip.com/2zxYA0bELPlv/Apex-Rollbar-Callouts
When the user wants to perform the callout synchronously or from a future, this is also supported: