Basic config options: Environment and enable/disable options #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltjones
force-pushed
the
wj-basic-config-options
branch
from
8171793
to
ff88fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new options to the setup and configuration pages:
ReportUncaughtExceptions and ReportFlowErrors
Salesforce routes exceptions and Flow/Process errors to the same email handler. These options allow Rollbar to handle only Exceptions or only Flow/Process Errors, or both.
ReportUnknownEmailType
The email handler may also receive email types besides Exception and Flow/Process emails. This option allows sending these to Rollbar as generic messages, or not.
SendReports
This enables/disables sending occurrences to Rollbar, allowing sedning to be disabled without needing to uninstall the package.
Environment
Allows setting the environment string sent to Rollbar with each report. Unlike the option in the Config object in earlier package versions, this setting is global, and works for all occurrences including uncaught exceptions and Flow/Process errors.
A few other fixes have been bundled into this PR. These are each in their own commit for easier review:
Fixed stack frame parsing
Several known stack frame formats weren't being handled correctly and would cause unhandled exceptions, including stack frames from Trigger classes, and stack frames from test classes. This update handles known and unknown cases safely.
6d6bc3c
Setup works when API permissions are already set
After uninstall/reinstall, or partial install, it's possible to have Rollbar API callout permissions already enabled in Salesforce. This update ensures Setup can continue successfully in this state. 03bd64c
Fixes a wrong type cast on assignment e7aafd6
Add the deploy dir to .gitignore 0c98278