fix: use callback for non-transmitted items

rollbar · Jun 28, 2019 · a41ac93 · a41ac93
1 parent e60cab0
commit a41ac93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/queue.js b/src/queue.js
@@ -89,6 +89,7 @@ Queue.prototype.addItem = function(item, callback, originalError, originalItem)
   this._maybeLog(item, originalError);
   this.removePendingItem(originalItem);
   if (!this.options.transmit) {
+    callback(new Error('Transmit disabled'));
     return;
   }
   this.pendingRequests.push(item);

diff --git a/test/queue.test.js b/test/queue.test.js
@@ -514,7 +514,9 @@ describe('addItem', function() {
         var queue = new Queue(rateLimiter, api, logger, options);
         var makeApiRequestStub = sinon.stub(queue, '_makeApiRequest');
 
-        queue.addItem({mykey: 'myvalue'});
+        queue.addItem({mykey: 'myvalue'}, function(err) {
+          expect(err.message).to.eql('Transmit disabled');
+        });
 
         expect(makeApiRequestStub.called).to.eql(0);