Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable/disable page telemetry (e.g. load events) #1035

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

This PR adds a telemetry enable/disable flag for "page" events. This currently applies to load and DOMContentLoaded events. In the current SDK, these listeners are only added in the snippet, therefore this change is for the snippet only.

In keeping with other telemetry flags, the feature defaults to enabled when the flag isn't present. Set false to disable.

Usage:

      var _rollbarConfig = {
        accessToken: "POST_CLIENT_ITEM_TOKEN",
        autoInstrument: {
          page: false
        }
      };

Notes:
The affected events were previously controlled by the network flag. This flag is unnecessarily broad, and disabling also disables all network telemetry (XHR, fetch, etc.) Additionally, the load events aren't directly network related.

This PR includes the rebuilt snippet.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes https://app.shortcut.com/rollbar/story/109193/

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@igoristic igoristic requested review from a team, dannyschnacky and nieblara and removed request for a team July 26, 2022 17:27
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waltjones waltjones merged commit f411e52 into master Jul 27, 2022
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
* allow enable/disable page telemetry (e.g. load events)

* update snippet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants