Allow enable/disable page telemetry (e.g. load events) #1035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds a telemetry enable/disable flag for "page" events. This currently applies to
load
andDOMContentLoaded
events. In the current SDK, these listeners are only added in the snippet, therefore this change is for the snippet only.In keeping with other telemetry flags, the feature defaults to enabled when the flag isn't present. Set
false
to disable.Usage:
Notes:
The affected events were previously controlled by the
network
flag. This flag is unnecessarily broad, and disabling also disables all network telemetry (XHR, fetch, etc.) Additionally, the load events aren't directly network related.This PR includes the rebuilt snippet.
Type of change
Related issues
Fixes https://app.shortcut.com/rollbar/story/109193/
Development
Code review