Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues #1044

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Fix CI issues #1044

merged 2 commits into from
Sep 14, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

CI started failing sometime after the last PR. There were two issues, fixed in this PR:

Type of change

  • Maintenance: test fix

Related issues

Fixes SC #115474

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones merged commit bf56f33 into master Sep 14, 2022
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@waltjones
Fix CI issues (#1044)
42aae51 
* test: update node dependencies to fix test failures

* test: update tests for async send
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijsnow ijsnow ijsnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waltjones @ijsnow