Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: make type for person.id nullable #1074

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

person.id in the Rollbar config should be nullable as documented.

Example:

    payload: {
      person: {
        id: null
      }
    }

This PR makes the Typescript type definition nullable.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #1058

https://app.shortcut.com/rollbar/story/120519

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link

@dbutts29 dbutts29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type when unsetting a person
2 participants