Add transmit option flag #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
Jun 17, 2019
| @@ -88,6 +88,9 @@ Queue.prototype.addItem = function(item, callback, originalError, originalItem) | |||
| } | |||
| this._maybeLog(item, originalError); | |||
| this.removePendingItem(originalItem); | |||
| if (!this.options.transmit) { | |||
There was a problem hiding this comment.
- This might be the right place, or perhaps this should go in
_makeApiRequest- what do you think? - Looks like we are no longer calling the callback - is that intentional?
There was a problem hiding this comment.
This location is (I believe) after everything the caller would want to execute without sending the request. At entry of _makeApiRequest is logically equivalent. Any later would engage rate limiting. (And maybe that's desired? I'm not sure, but I thought not.)
I skipped the callback, since this case neither has a response nor produces an error. But it probably needs to be called in order for async/Promise wrappers to work correctly. I imagine other situations as well. I'll add it.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support SDK dev options, adds the
transmitoption, defaulttrue. Set to false to fully process events, but not send to Rollbar.